Ask HN: Help me refactor this code please (Ruby)

1 pointsby grover_hartmannover 9 years ago

It's basically a vending machine simulation, I want to refactor it into two classes, a model (VendingMachine) and a Controller. I'm not sure what else to do. Please help.<p>https://gist.github.com/anonymous/a978dcd30383f3e618e5

2 comments

grover_hartmannover 9 years ago

So I would like to rename VendingMachine to Controller and have a VendingMachine model where I move #vend and #refund to it.<p>I'm also not very happy with #menu being this large in LoC. What would you guys recommend?

评论 #10095302 未加载

technionover 9 years ago

Think about types. You call .to_i on the balance, so it can only initially be an integer. But you have items costing 1.50.