TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Git Reflow

109 pointsby jaybosamiyaabout 9 years ago

8 comments

32bitkidabout 9 years ago
The &quot;squash and merge&quot; trend with git bothers me, and perhaps I&#x27;m &quot;doing it wrong&quot; but it just doesn&#x27;t capture what I need a commit history&#x2F;git-blame for. Usually, I don&#x27;t care what <i>feature</i> a line code was for. I want to know <i>why</i> a developer thought that was the right change. And to get that visibility I tend to make lots of commits, treating commits almost as out-of-band comments that don&#x27;t clutter the file&#x2F;repo.<p>When I think I&#x27;m done with a feature is exactly the time that metadata becomes relevant! Why would I want to lose it?<p>If anything, I wish ides would integrate git-blame more into my visualisation of a file<p>But there are so many people into it, that I feel I must be missing something obvious and it bothers me.
评论 #11732819 未加载
评论 #11732622 未加载
评论 #11732912 未加载
评论 #11733594 未加载
评论 #11734477 未加载
评论 #11732576 未加载
评论 #11732660 未加载
评论 #11735467 未加载
评论 #11732675 未加载
评论 #11732956 未加载
评论 #11733864 未加载
codenamevabout 9 years ago
As one of the maintainers of git-reflow, I understand the controversy over squash-merges. Personally, on all the projects I&#x27;ve worked on with this workflow, I have yet to find any drawbacks when needing to use git-blame; although is not to say that there is no value in maintaining a full history nor that it is our way or the highway. We like to keep all changes in context of a feature.<p>We have worked in environments that promote rebasing of feature branches, and while that may work well, it can lead to holes in the history of the review process due to the need to force-push.<p>That said, we are nearing a stabilized core API and have plans to allow for more flexibility in the process. If you are interested in following our ideas behind this, feel free to follow the issue we have open: <a href="https:&#x2F;&#x2F;github.com&#x2F;reenhanced&#x2F;gitreflow&#x2F;issues&#x2F;53" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;reenhanced&#x2F;gitreflow&#x2F;issues&#x2F;53</a>
jupedabout 9 years ago
Another &quot;I like to deliberately lose information to no benefit because I&#x27;m bad at git&quot; &#x27;workflow&#x27; hits Hacker News.<p>Something is deeply wrong with the ecosystem when people want to do things like this!
评论 #11733436 未加载
评论 #11732886 未加载
评论 #11732653 未加载
andrewchildsabout 9 years ago
From the README:<p><pre><code> $ git reflow setup Please enter your GitHub username: nhance Please enter your GitHub password (we do NOT store this): Your GitHub account was successfully setup! </code></pre> That implies that the username is actually stored somewhere. Is it stored locally or on some reenhanced.com server? The README should be very clear about what exactly gitreflow stores and where.
评论 #11733073 未加载
评论 #11732903 未加载
评论 #11732804 未加载
teenabout 9 years ago
This seems super useful- it matches my team&#x27;s workflow, I&#x27;ll def suggest we try it. Squash merge ftw
评论 #11732462 未加载
Dru89about 9 years ago
I&#x27;m unhappy with the approval process being a simple search for &quot;LGTM&quot;. I wish GitHub pull requests had actual support for a review process, e.g.:<p>* open issues to address<p>* review state, such as &quot;changes requested&quot; or &quot;approved&quot; (along with users that are in each state).<p>We&#x27;ve been using Phabricator&#x27;s[1] Differential tool for code reviews and it feels superior to this process, but it would certainly be nice to have an all-encompassing solution for this.<p>[1] <a href="http:&#x2F;&#x2F;phabricator.org" rel="nofollow">http:&#x2F;&#x2F;phabricator.org</a>
评论 #11735082 未加载
评论 #11735948 未加载
tjbiddleabout 9 years ago
Created something in-house very similar for a job a few years ago; We could accept a ticket, it would create a feature branch, update the ticket and comment on it that it was being worked on, then when we submit, it would update the ticket status - assign it to a reviewer, squash commits, create a pull request and comment with the link.<p>This project seems to be done much cleaner though and in a more abstract and reusable manner. Well done!
bsimpsonabout 9 years ago
So...it&#x27;s Gerrit&#x27;s workflow for GitHub?