TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Require multiple reviewers for pull requests

80 pointsby clarkbwabout 7 years ago

4 comments

scarmigabout 7 years ago
Having multiple reviewers is often <i>bad</i>. A diffusion of responsibility means no responsibility.<p>If you have three reviewers, no one feels personally responsible for checking it line by line and thinking about the code in depth. Instead a cursory glance seems acceptable, because, after all, other people are looking at it.
评论 #16664436 未加载
评论 #16663333 未加载
评论 #16664130 未加载
评论 #16663507 未加载
评论 #16663269 未加载
评论 #16663294 未加载
评论 #16663426 未加载
评论 #16664959 未加载
评论 #16663184 未加载
评论 #16663389 未加载
haneefmubarakabout 7 years ago
I think the next step from here is giving the ability to assign maintainers for certain sets of files (in this directory or matching a particular regex) and then when a pull request comes in, GH can looked at the changes, match the maintainers, and require all of them to sign off prior to allowing merging.
评论 #16662321 未加载
评论 #16662770 未加载
评论 #16662313 未加载
评论 #16672998 未加载
chadashabout 7 years ago
TLDR: github has a new feature that allows you to require X number of people to approve a PR before merging to a protected branch.<p>From the title, I initially thought this would be an article about <i>why</i> you should have multiple people reviewing PRs, which sounded ridiculous (obviously we don&#x27;t all have the time&#x2F;resources for that).
评论 #16662658 未加载
tomwalkerabout 7 years ago
Blockchain for source control?