TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Code Review from the Command Line (2018)

58 pointsby nik1aa5about 6 years ago

6 comments

badfrogabout 6 years ago
Reminds me of Jane Street&#x27;s code review in emacs: <a href="https:&#x2F;&#x2F;blog.janestreet.com&#x2F;putting-the-i-back-in-ide-towards-a-github-explorer&#x2F;" rel="nofollow">https:&#x2F;&#x2F;blog.janestreet.com&#x2F;putting-the-i-back-in-ide-toward...</a>
gfioravabout 6 years ago
I’ve gotten used to Vimium [0] (a chrome extension that emulates Vim commands in the browser) and I rarely use the mouse or arrow keys now. For me, that has been the biggest leap in productivity for my CRs.<p>I agree that it’s nice to review within the context of the terminal, but I still think the UI (at least for Github) is easygoing and productive (specially when you ditch the mouse).<p>[0] - <a href="https:&#x2F;&#x2F;chrome.google.com&#x2F;webstore&#x2F;detail&#x2F;vimium&#x2F;dbepggeogbaibhgnhhndojpepiihcmeb" rel="nofollow">https:&#x2F;&#x2F;chrome.google.com&#x2F;webstore&#x2F;detail&#x2F;vimium&#x2F;dbepggeogba...</a>
评论 #19825567 未加载
Boulthabout 6 years ago
I thought it will be about git appraise (<a href="https:&#x2F;&#x2F;github.com&#x2F;google&#x2F;git-appraise" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;google&#x2F;git-appraise</a>) but it&#x27;s still interesting. Thanks for sharing!
GordonSabout 6 years ago
I&#x27;ve been using GitHub&#x27;s code review features a bit recently. Something I really like is the ability for a reviewer to quickly make suggested code changes that the reviewee can can approve with a button push, instantly committing them. This saves a lot of time, especially for small, relatively insignificant changes.<p>Overall though I find GitHub&#x27;s code review a bit fiddly and awkward, and it&#x27;s features aren&#x27;t &quot;easily discoverable&quot;. Using the feature I mentioned above as an example, it&#x27;s rare that reviewees actually know about it, or see and use the &quot;Approve&quot; button.
评论 #19826674 未加载
orphelineabout 6 years ago
This is a nice workflow - thanks for sharing!<p>We&#x27;re using Bitbucket, not GitHub, but this would mostly work there too.<p>The one thing I was hoping to see and didn&#x27;t was adding review comments from the command line. It&#x27;s appealing to review changes in the terminal, but if I have to open another tool to comment the utility drops.
sys_64738about 6 years ago
# apt-get install tig