I have been working in an investment bank for the past months(my first job), and I was surprised to find out out that my team doesn't write any tests at all.<p>There is also no code reviews, you are responsible for your own code. There seems to exist a "hustle" mentality, where you need to ship at all costs, the engineers frequently work from 9am-9pm and then some weekends.
Is this common practice in the industry?
Testing is valuable but my opinion of it has changed over the years.<p>On a new/fast evolving product I prefer to have a solid suite of integration/e2e tests and a lighter unit test suite near the edge of a server with no mocking of deps (e.g. if it uses a db, spin up a local instance). I would also test something that is non-trivial to understand or a critical dependency in the system e.g. a rules engine.<p>The reason being is - the code is in so much flux that the internal interfaces change constantly. In agile new requirements come along and you end up chucking a lot of the old code out of the window and wasting time.<p>As you move towards completion of the project and the internal interfaces shore up then increase the tests. So when it’s in maintenance mode someone else can easily make modifications and has documentation on maybe why something works in a certain way
It’s worth remembering that engineers don’t get paid to write tests, they get paid to produce software that supports some business need. In most circumstances, some amount of automated testing makes it faster to reliably meet those business needs.<p>If you’re building a lot of small, one-off tools for internal use, it may well be the case that some limited manual QA or UAT is sufficient to ensure that your work is good enough.<p>If you’re working on larger, more complex projects that are frequently updated, the shorter feedback loop that some amount of automated tests provide will probably save time and money by catching problems earlier, avoiding regressions, and reducing the need for repetitive, time-intensive manual testing.<p>But in any case, your testing needs will always be highly specific to the actual nature and needs of the project.
Yes, this is all sadly common. And those traits you mention all go together!<p>Let’s be clear, most of the software empires of the present day were built on this style. It is possible to ship software like this!<p>But if you do neither testing nor code review, you almost certainly have a team that thinks downtime is for losers and heroes are coding 24/7. I believe they get addicted to the twin dopamine hits of cranking out code and saving the company from disasters that their code causes.
> The engineers frequently work from 9am-9pm and then some weekends. Is this common practice in the industry?<p>Yes, quite common. I've been a software engineer in the Investment bank industry for about 15 years, worked at various hedge funds, brokerages and asset management firms in Boston, NY and recently in San Francisco.<p>Just 1 out of 6 firms I worked at had any kind of test driven development. In my experience, the lack of testing is not from a "hustle" mentality. It has more to do with the fact that the Fintech space in general, and investment banking in particular always lags behind in technology and processes. In companies that I tried to incorporate some sort of unit tests and TDD, the push back always was "We don't have time in the project timeline for writing tests. There is a QA team that will do that." Either the benefits of tests in software development process hasn't been "sold" to the IT Managers, or they are completely unaware of it, coming from a traditional waterfall methodology.<p>Another thing that's been the driven of this workflow is that traders and portfolio manager routine so some sort of un-scalable automation for their workflow. I once worked with a Bonds trader who had an enormous spreadsheet with over 80 tabs, links to bloomberg realtime pricing, a bunch of macros and such. The work that my team used to get was to take that spreadsheet and turn it into a database driven application that wouldn't "Freeze" or "choke" periodically as it used to in Excel.<p>In such situations, which is also very common and you'll likely run into it, your manager will ask you to work with said trader or portfolio manager and do the conversion. In these type of projects also I wasn't allocated any time to write tests. As soon as a portion of the application is ready, the traders or PMs would themselves run tests against a QA instance. In order to keep my sanity, I would write tests that wouldn't be in source control and wouldn't tell my manager about it.
One of my colleagues once showed me millions of $$$ flowing through functions called `func1`, `func2` etc., both of them are over 1000 LoC. There are many SQL queries more than 100 lines long. Overall it's a huge application with extremely difficult use cases. And yes, there is not a single automated test scenario. But the company is more or less happy with this system and their manual testing. That said, it's a 20 year project and it has probably helped to earn some good money. So, if that project can be successful, any project can. There are bugs and it is has some serious issues, but it is possible to deliver something actually useful w/o tests.<p>I would assume, it's possible to go without automated testing when your business logic changes every now and then. Not that you necessarily should.<p>> There seems to exist a "hustle" mentality, where you need to ship at all costs<p>I'm still to see a developer with experience in the banking industry, who would praise its working conditions. "Low"-tier workers with 25-50% developer salary usually have to deal with even worse conditions.<p>Remember, working 60h+ a week can lead to unpleasant health problems, both physical and mental.
<i>Is this common practice in the industry?</i><p>Yes, and so are burnout, abusive interpersonal behavior and the physical / mental problems that inevitably go along with such working environments.<p>But there's no reason you need to put up with it any longer than absolutely necessary. Do yourself a favor and find another job as soon as you feel you've had enough.
Whether it's common or not, is this the right place for you? Stepping into a tire fire for your first job runs the risk of burning you out early and cementing lots of bad habits.<p>If you do want to stay there, there's a vast happy medium between "no tests at all" and "test driven development". Check out the "git effort" command for a list of the most-changed files in the codebase. (If it's not installed, try looking for a "git-extras" package for your operating system.)<p>The files changed most frequently are often also the ones most in need of refactoring and tests. If nothing else, you can cobble together a little test suite of your own and be the guy that finds bugs faster and introduces fewer new bugs.
How common? Very, I'm sure. I've worked with and for plenty of people who focus entirely on getting a MVP to market.<p>To these people, testing slows you down, costs more and they often can't be convinced otherwise. Even when a massive cascade bug costs them real money, that's seen as your fault, not one in the development process.<p>If you're facing this, and nobody is willing to help you put it right, run away as fast as you can. This job will destroy your soul and forcibly make you a worse developer.
Very common in my experience. In 16 years and 4 different companies, I've only worked on 2 projects (of dozons) that had a well established test process. The 2 projects in question were also, coincidentally, the only greenfield projects I've worked on. Almost everything else has been legacy enterprise stuff.<p>Most places have had some kind of review process, but not all. My current job has no tests, no reviews, and no restrictions on committing to trunk/master.<p>The funny thing is, I haven't noticed that big of a difference in software quality, but the places with no tests/reviews are way more productive.<p>Your milage, of course, may very.
The problem is not about the tests but the long working hours. Do not give your time for free, the company just gets used to it and they will fire you the same when they do not need you anymore, or you get personal responsibility that don't allow you to work for so long.<p>When you get a better job then think about tests. Your health is first.
20 years a contracting maintenance programmer. Almost all systems I've dealt with in that time were a <a href="https://en.wikipedia.org/wiki/Big_ball_of_mud" rel="nofollow">https://en.wikipedia.org/wiki/Big_ball_of_mud</a><p>Along with this they have had no automated testing, little documentation, one shared dev/qa environment and in most cases not even bug tracking.<p>I've only worked on one "green fields" project where we did TDD, CI, dev/qa/staging environments, etc. It was a wonderful time and I truly miss it.
depends a lot on the industry and what you're building. Like when I was in the web/startup space, literally nobody worked how you're describing; everyone wrote tests. Transactional systems are naturally testable. It's easy to craft or record http requests and play them back, for example.<p>But now I work in the game industry, and when I talk to game developers, automated testing is seen as being pretty advanced for a lot of the work. The products are extremely stateful, and automating the testing is extremely complex. Real cases that cause bugs are things like "if you stand on this specific rock and strafe to the right and perform a back-jump while z-targeting an enemy to the west you'll clip in between these two other rocks and get stuck". The testing process becomes incredibly hard to instrument, and for that sort of stuff, manual QA winds up being the more common pattern.<p>what's the cost of automated testing? what's the cost of manual testing? what's the cost of NOT testing? The answers to those vary from domain to domain, and from project to project.<p>If the cost of automated testing is lower than the cost of not testing, it's irresponsible to NOT do automated testing. That scenario is extremely common in the design of transaction-handling systems.
It's pretty common outside of startups and Big Tech. My boss at my first job told me specifically to "not waste time" writing tests, which I thought was insane and I ignored him since the were having me write a system for charging subscriptions.<p>I'm fine with not writing tests so long as I'm not held responsible when something unexpected happens. Unfortunately for you, they are making you responsible for your own code <i>and</i> have no form of code review.<p>If you can, you ought to write tests anyway as a part of your work, even if it's just a handful of end-to-end tests to ensure you don't cause anything catastrophic. And if they ask you for an explanation, just tell them that having those tests in place helps you get more work done and not waste time.<p>There's a chance they're going to be irrational and opt to run their own software into the ground long-term. If they tell you not to write tests, I'd suggest continue working there until you've held your position for a year and, in the meantime, keep looking out for better opportunities. The reason I say that is because if you adopt their cowboy-coding culture long enough, it will sink in with you and it will be harder for you to adopt best practices at your next employer.
I've also experienced this in many companies. It has led me to question if tests are actually a good thing. The goal is never to write perfect code, the goal is to ship a product and many companies does this fine without testing.<p>Are we actually doing things too complicated and too good for the business case?
Testing is always necessary. Automated testing isn't. It generally requires double the manpower early on, and only saves time later on. It's a good way of throwing more bodies at a problem - someone can write tests and not step on the toes of someone else writing the features.<p>But testing always needs to be done. The most common way of doing it is manually. Huge companies with thousands of employees still do it manually. One company I worked for had hundreds of pages of tests to manually do, because we were building both the hardware and software iteratively. There were logs and automated tests. But the simulated environment can be flawed and logs take a while to spit out. It's more accurate and faster to do all of them manually at the end of a sprint.
I’ve seen this before. It’s not common practice as far as I can see but it does happen. I blogged about it here as ‘discounting the future to zero’<p><a href="https://riskfirst.org/Evaluating-Risk#discounting-the-future-to-zero" rel="nofollow">https://riskfirst.org/Evaluating-Risk#discounting-the-future...</a><p>Although it’s sometimes reasonable to not write tests, this kind of thing usually happens when everyone is being threatened with the sack on a daily basis, rather than lacking engineering skills
Tests and code reviews aren't right or wrong, but take this opportunity to form your own opinion of how you would like to work, and be sure to ask about it when you are interviewing for your next job.<p>Just as some would run screaming from a place without mandatory code reviews, others would run screaming from a place with mandatory code reviews.<p>You should be able to get close to real answers about these practices during interviews, there may be some bias towards aspiring to have tests and code reviews, but asking for details should filter out aspirations from actualities.<p>On the other hand, 12 hour work days, with weekends is clearly bad, and it may be hard to tell who is saying the things you want to hear, only because you want to hear it.<p>Having a good reason to not be in the office crazy hours is something to mention in interviews "i've heard [industry] can be crazy, but i've got a strict schedule because of X, that won't be a problem right?" Bonus points if you can come up with something plausible, true, with positive connotations and something they wouldn't get in trouble for asking about.
Engineers just end up performing the tests manually and with each release. Or they don't and it blows up somewhere down the road.<p>Some open source projects I've seen don't have too many tests. IIRC the source for uBlock Origin doesn't have too many tests in it. But it's small enough that a motivated maintainer can keep the quality high.<p>For what it's worth, I worked at a Fintech company that built trading systems for the FX marketplace. They had automated tests out the wazoo and a super thorough and on-the-ball QA team. YMMV.<p>I'm curious, for the projects you worked on in the Fintech space, how much money could be lost due to software glitches? At this firm I worked for they were responsible for the gain/loss if a bug caused a trade to go into an error state. So it could easily cost ten to hundreds of thousands of dollars in a few minutes during market volatility. A friend of mine had a bug slip into prod and it cost the company $90k.
I'd say no tests isn't an automatic red flag. A working build system and some sort of version control are far more important than tests. I've worked on a few large (>500kloc) codebases with no version control, no tests, and no build system (that last bit is the actual shocker). In most cases, I slowly added version control, tests, and CI.<p>However, convincing management that things like tests (or even version control) are worthwhile can be an uphill battle, and they're right to question why you'd want to do do unnecessary work. I'd say it's quite common to skip unit/integration tests (let alone CI) anytime you're working outside of the tech industry. It's also not necessarily a bad thing.<p>If the project is mostly a gui with little core business logic, it's actually relatively hard to test what really matters (responsiveness, weird UI bugs on different platforms, etc). That's not to say you shouldn't, just that you should be a aware that CI only gets you so far. Most places I've worked deliberately eschewed unit/integration tests on software along those lines in favor of a very manual QA testing. It's different, but it's not wrong.<p>And now the war story: The project with no build system was a disaster. No tests are fine... I can live with that. No version control was annoying, but fixable for the future. The lack of a build system was really puzzling. What build system there was consisted entirely of shell scripts (and CSH, at that). I realized while trying to get things to build on a modern compiler that a key binary had not been successfully built in over a decade. No one noticed because the shell script 1) didn't fail when the build failed, and 2) touch-ed the binary even if the build failed. End result was a recently-timestamped binary that was actually last built on RHEL3. It also explained several long-standing critical bugs that the previous developer insisted had been fixed a decade ago.
You're talking about an industry where software is a cost. IT is generally a cost for all those companies whose business is "something else". For me obviously this is short sighted, however, that's the way it is. I have experienced once an ecommerce company where there was a single function with something like 15k LoC, and this was handling with global variables the entire shopping flow. Untouchable and obviously untestable. I'll tell you, the same software I am quite sure it's still running and making money. So yes, it's quite common. All those tech talks, software conferences videos, best practices... And then you work on such crap, it's totally demotivating, I know the feeling.
Conversely, there are plenty of organizations who rely only on unit tests and no QA team of any kind. This is bullshit. Plenty of bugs slip into production and we have thousands upon thousands of unit tests.<p>I for one believe unit tests are not the be-all, end-all that most of the industry has swallowed hook, line & sinker.
I've been in this kind of place once, but it wasn't web dev. I was writing calibration and test software for fiber optic switches. In that particular case, you really can't mock out the real world behavior of a specialized piece of hardware that doesn't exist anywhere else.<p>Granted, there were theoretically some bits that could have been tested using automation, but those weren't the bits that ever caused any trouble.
One of my interview questions when interviewing with a potential employer is: "describe your test infrastructure" and then ask them to dig into how they test different facets of their product. I will not work at a company that does not write and value tests. It's not worth the headaches.
So common it has a name:<p><a href="https://en.m.wikipedia.org/wiki/Cowboy_coding" rel="nofollow">https://en.m.wikipedia.org/wiki/Cowboy_coding</a>
I don't work in Banking but I do work in healthcare and testing is required.<p>No code makes it to Master if it doesn't have any tests.
We do unit tests, integration and EtoE testing with a few full-on regression tests being thrown in here and there when we do a major upgrade.<p>At first, I thought that maybe we were kind of overdoing it but as the codebase is expanding, I find it actually quite easier to refactor old code when I know there is a test covering that piece of code that I have just replaced.<p>As for the excuse: there is no time to write tests, you simply need to change the estimate of your story during the sprint planning.<p>Even for my own personnal projects, I write tests.
It's good practice and it makes me more confident when I add a new functionnality.
depends on the culture and on the goals of the company. Testing is an important best practice, but all "best practices" exist to enable the company to be successful. In your case it sounds like the work is focused on prototype projects, so "ship at all costs" sort of makes sense.
Quite common in early-stage startups, 2-5 people including founders. As soon as the MVP is ready (first 3-6 months usually), they start around organizing things and prioritize stability, robustness over speed of delivery.<p>If the early engineers were experienced guys, a basic test suite and deployment pipeline would have been the first priority at the onset. It makes releasing frequent commits a breeze. Or else, they learn from subsequent hires to organize code, write tests and add extra processes. If they fail to hire such talent, they learn the hard way, frequent downtimes leading to user frustration and failing to retain them. It's crucial they realize this early on though, otherwise, this could lead to things blowing up pretty quickly leading to the death of the product.<p>Although I'd say, it sounds unusual for an investment bank. Doesn't sound like a company anyone would stick around for long. Sounds like inexperienced engineering leadership. If you're early in your career, I'd suggest looking for better companies.
Here's an in-the-spirit-what-they've-said quote from 6 of my former clients & a couple bosses:<p>- "I'm not a fan of testing. I'll add tests if management asks me to and budgets time for adding them."<p>- "We've got 100% test coverage."<p>- "We test everything."<p>- "Testing is too hard for this kind of work."<p>- "We over-test everything, and the test suite is damn slow."<p>- "We have two test suites, the OLD one and the old one. Neither of them can be run reliably, and trying to get them to work is gonna take more work than just coding up an untested solution."<p>So in my own personal experience, I've 50% pro-testing and 50% without much testing. Personally I'm pro testing. That being said, I'm not such a zealot that I'll impose my views on others. When I'm in charge, if there weren't tests before, we'll start adding them for sure.
What do you care if it is common for? Just start improving the situation. Set up Continuous Integration, add high-level smoke checks to catch the simple silly things, then make sure to always create a reasonable set of automated tests for whatever new you build. Does not have to be TDD to give benefits.
Pretty common, though it depends a lot on the company, industry, how tech focused they are, etc.<p>A company who doesn't care much about tech won't build tests or have code reviews. And if their team is small enough, you probably can't blame them for that, it'd be difficult enough to keep up with client/company demands.<p>There are also an awful lot of programmers whose skillsets haven't really changed for a decade or so, and companies with this sort of team probably don't use much in the way of automated tests. Then again, there are quite a few of them that don't even use version control, or a staging site.<p>And yes, there are places where that hustle mentality is in play too. Often startups whose team falls in the above two categories.<p>But as said, it depends on the industry and company.
My project (that I'm currently trying to get away from) is a large project that has been cobbled together over many years from many different teams both internal and external.<p>In the beginning everything was done to get something shippable and now that the project has shipped it is a monolithic monstrosity. Several devs have made an effort to infuse unit testing into the project but they always fizzled out because estimated dev time never included testing and so if a crunch happens now then the first thing that is dropped is the testing effort. I have learned a lot from my project however it's a lesson in how not to do things.<p>I will say that code reviews are heavily enforced. So we at least have that.
Automated testing is just the question of your own style. What do you like to do more: debugging the problems or try to write a lot of testing code upfront and before the actual code.<p>Long hours are about work and pay. Never let the sense of guilt into it. It is not related to the 'quality'. You've got certain value of throughput (how much stuff useful for the client you can make per hour), and that's it, that's your value per hour. You don't increase it by working for more hours. Divide the pay by your de-facto hours (if you want to take more of them), see if it's a good deal for you.
Unfortunately, that's the case in most small IT shops. It might be a large bank but I bet the programming team is small relative to other depts. It is just expensive to hire someone to test code. Most general managers don't understand that programmers need help testing code. From their point of view, programmers need to produce error-free code. It takes a strong IT manager to make the case of why new code needs to be tested after a programmer delivers it.<p>So yes it's common but you could make the case for unit testing and that will make your life a lot easier.
It's more common in enterprises than you would think. Remember, automated testing is a fairly new concept. Some of these applications and developers have been doing it the same way for 15 years.
> <i>the engineers frequently work from 9am-9pm and then some weekends.</i><p>Marginally related:<p>* Chinese Devs Using GitHub to Protest 996 Workweek (9am – 9pm, 6 days/week)<p><a href="https://news.ycombinator.com/item?id=19507620" rel="nofollow">https://news.ycombinator.com/item?id=19507620</a><p>* 996, GitHub, and China's digital workers rights awakening<p><a href="https://news.ycombinator.com/item?id=19629464" rel="nofollow">https://news.ycombinator.com/item?id=19629464</a>
We've open sourced our integration tests for our API: <a href="https://github.com/serpapi" rel="nofollow">https://github.com/serpapi</a><p>However we've really little unit tests.<p>There is balance between what tests are useful and which are not. Testing for sake of testing can be counterproductive. However in your case, it seems there is no reason to skip some form of testing or code reviews. Some companies have just bad practices.
an effective alternative to writing coding tests is to automate the comparison of output data between old code -vs- new code using same set of input data ... this is valid when the initial few prod deployments had people manually confirm the output data was as expected<p>I worked in a global investment bank for many years on very large teams building systems responsible for processing hundreds of billions of $ in real time trading transactions where this approach not only worked it facilitates extremely productive use of software engineering talent<p>We also published prod data tapped and published from various points in our data processing pipeline which was subscribed to by QA prod-parallel which did the burn in of all new code ... it was fed live prod data and output of QA was compared to prod output in real time<p>I created a fuzzy match process which gracefully handled gradations of data match when faults where encountered when comparing data feeds from prod -vs- QA ... this allowed people to focus on chasing down the data diffs and not wasting their time writing coding tests which would have been very quickly obsolete
I've worked in banking projects with no automated tests. You end up manually testing only what you think might break with new code. The stakeholders expectation is that things might break once in a while as long as you can fix it.<p>For me testing at its most basic level is kinda like insurance, you might live without it but it helps a lot when problems arise
It is very common. But it depends upon who leads the team and how many resources they have.<p>When I hire a new developer, I always have them read TDD and Clean Code. Even if they don’t get it right away, I aim to get them to pause and think about it.<p>Some quick software that was written in haste could be running over a decade. And they might be stuck maintaining it
In 20 years I've never been in a project where tests were written rigorously. In fact, in the majority of projects there were no tests at all.<p>I don't think this is completely wrong though. The technological landscape moves so quickly it may not make sense to build some types of projects as if those were going to last 20 years.
best situation I was in, we had a conference/group communications tool. Had a 'bot army' where each bot jumped around in the group space, turning mic on and off and texting. Wouldn't release until 100 bots could go all night and neither the client, server nor media node had problems.<p>That was a solid product!
Quite common in consulting. There's no hard requirement for automated test coverage but typically we have dedicated resources for integration and UAT testing throughout the build phase of a project.<p>Code reviews are rare too. Often times you'll be the sole developer working on a particular component of a solution.
I think the hustle mentality is a different issue, and I would be very hesitant to conflate the two or to entangle them in some way. It is unfortunately common, in my experience, however I hope you are looking for something else.<p>In my experience (20+ years of writing software professionally) I've never built an automated test. I've never used an automated test.<p>My preference is to write code and push it straight to production without even debugging it. tested afterwards, certainly, but if you're in such severe doubt that you're going to ruin the system, you need some serious code review.<p>My strong belief is that you cannot test your code into goodness, that is something that only a person can evaluate. By making myself better at coding, by not relying upon something else to make my code good for me, I am way more efficient than I could be otherwise. Given, this may limit the types of projects that I engage in, and certainly changes the project flow. However, when I look at my productivity as compared to others, I don't find any problems in my method.<p>Only human eyeballs can find some problems, despite how many cases you throw at something with automated testing.
As a consultant who often comes in to fix broken projects after the team who built them has moved on? Pretty much universally true. I’ll often start a test suite that covers the parts I’m fixing, but I have yet to come across a client project where I said “Wow! This has a great test suite!”
This is very common in the web agency world, where budgets and hourly rates intersect at a place where there's hardly enough time to build out features. Testing is seen as eating up time that could be better used getting through the backlog.
Tests are not terribly common in the games industry (at least in the traditional AAA space). Code is still reviewed, but it's brisk.<p>This is probably because the product involves shipping a box and then never looking at the code ever again.
Personally, I don't do tests on my projects, it's a weak guarantee in my opinion. I prefer formal proofs...
Working on a language for automatically managing the same..
Gothub.com/onchere/whack
Engineer? Huh. In Mechanical Engineering, they use stress-strain curves to determine if components can handle the load. ie, they test.<p>Software engineering is often a lie. Sorry, but it's not engineering.
It is very common. But the money is good, isn't it? :) If it isn't then you are missing out on the only real benefit of working in the finance industry.
I've been programming professionally for 19 years.<p>I've been given permission and time to write tests for 9 of those years, at only 2 out of 6 total companies.
Developers who don't write tests are lying to themselves about the quality of their work.<p>Without tests - automated, UI, unit or otherwise - you really can't evaluate your quality metric.
I have been in some, with disastrous results.
I think it happen in startups so often than I mostly blame the downfall of them to <i>not testing</i> culture.