TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

XSS vulnerability found in Github

69 pointsby Stukover 14 years ago

5 comments

pilifover 14 years ago
This might look really funny, but consider this: The javascript you are executing there runs on the github domain. So it can do whatever you can do by manually clicking.<p>The injected script could for example submit a new SSH public key for your account (doesn't require your password again). Or just be funny and delete repos. Or just upgrading your account to a bigger, more expensive plan.<p>Or they could get a list of your private repositories. Combine that with the upload of a new private key and you'll get free access to proprietary code of any account.<p>Aside of fixing the XSS issue, they really should ask for the password again when uploading a public key.
chrisbroadfootover 14 years ago
Seems to be fixed now.<p>Quick work by the github guys, kudos.<p>For those who missed it, the title attribute inside commit messages in the file list wasn't HTML encoded.
评论 #2024421 未加载
mike-cardwellover 14 years ago
Didn't work for me. Then I remembered to tell noscript to enable js. Does anyone still need convincing that they should be using noscript?
评论 #2024409 未加载
评论 #2024376 未加载
评论 #2024249 未加载
评论 #2024250 未加载
评论 #2024273 未加载
Stukover 14 years ago
Something @chrislloyd and I found in Github. Nothing too serious!
评论 #2024199 未加载
评论 #2024175 未加载
评论 #2024383 未加载
评论 #2024189 未加载
评论 #2024201 未加载
Garbageover 14 years ago
Not working for me. Is it fixed? I can see only JavaScript. IE8 on Windows XP.
评论 #2024347 未加载