I'm trying to improve the accessibility of the company's website.
I created a merge request where I change the wrongly used attribute `role` into `data-role` to avoid the browser to misrepresent it.
I also updated the Unit Test and End to End tests.<p>A colleague is strongly opposing, and will not let me merge it until I find a customer that contacted the company because it's affected by this issue.<p>What can I do?
Port the entire app in to React so you don't need to use attributes to store state. ;)<p>More seriously, working with people who don't care about what they're building enough to want it to be a better product is hard. I don't really want to recommend that you resign and find a new job, but two decades of experience writing web software tells me that's probably the only real solution. If you're on a team with people who don't <i>actively</i> want the code to be as good as possible, and who are willing to put the effort in to making it that way, will be bad for your mental health and possibly bad for your career if you pick up that habit.
There are probably dozens of reasons both good and bad for preventing fly by night change requests. Some of them would depend on the size of your company. Is this the work the company wants you to do or are you off the on your own?<p>Tossing aside the accessibility angle, fly by night changes often have ramifications that the authors did not anticipate. I have and would again veto change requests that not part of our planning process and offered as: "Surprise, here is this cool thing I did."