The title of the article is "How to do code reviews" yet all the content is around why code reviews are done and what the goals are. And the content itself is pretty light - the second half is just rehashing the first half, which are all bullet points.<p>I'm curious how it made it to the front page and if some of the folks who thought it was useful could comment about how it helped them understand <i>how</i> to do a code review?
Nice list but for me missing the most difficult pieces<p>- while giving a review, how to not focus on superficial details but instead really take the time to understand the problem and the solution. Making sure you can really understand why things were done the way they were and thinking about whether things could be made more clear, performant, follow best practices more closely, etc<p>- when receiving a review learning that people are reviewing it your code not you, learning how to look forward to reviews because they make your final product better<p>Would love to see advice on the really difficult bits of code review
The article is more why than how, so I have a question for HN. Is it acceptable for a company to not do code review until late in the funding game (like series E/F)? Like move fast and break things to get MVP going and break a lot of best practices doing it, and at what point should that be reigned in?<p>Imagine you are at a unicorn with physical product already operating in public, and a C laughs at a suggestion of code review and says its too long, hard and expensive. What would you do?
Good post on the what.<p>This one on the human/how: <a href="https://dev.to/solidi/be-a-rockstar-at-pull-requests-1e4f" rel="nofollow">https://dev.to/solidi/be-a-rockstar-at-pull-requests-1e4f</a>
This is more of a list of "why" you do code reviews rather than how to do them. In my opinion the way to do code reviews is to be didactic. The point is not <i>just</i> to tell people that there are problems, but to explain why they are problems so that the developer can learn and avoid making similar problems in the future.