TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Ask HN: What does your change/pull request approval process look like?

1 pointsby tr1coderalmost 5 years ago
I&#x27;m curious what the process from opening a change&#x2F;pull request to its approval&#x2F;merger look like for folks out there.<p>In my company there are projects where the PR would first go through code review and then QA where there is more available developer time to do reviews than QA engineer&#x27;s to QA. And then there are projects where the developer time is optimized (because it is scarcer) so the PR changes would be first manually tested by a QA and then code reviewed.<p>Then there are projects where availabilities of both are somewhat equal and we sometimes end up cycling a few times through: 1. PR opened 2. code reviewed 3. address code review comments 4. follow-up code review accepted changes 5. QA found issues 6. issues addressed 7. GOTO #2<p>I would like to try and optimize this so I&#x27;m curious what this process looks like for you and if you ever had similar issues and how did you fix them?

no comments

no comments