TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Ask HN: How to deal with hostile code review?

4 pointsby codingstuffsalmost 5 years ago
The small startup I work for is starting to do a refactoring&#x2F;version 2 of its product, as such the owner is going through the code base and marking areas for improvement.<p>He has marked a few parts of the code that I worked on, and one in particular has the comment &quot;&#x2F;&#x2F;codingstuffs: This code makes me want to cry. Try xxx coding style??&quot;<p>Now, I will be the first to admit that likely my code sometimes can be a little messier, but the coding style he prefers the pyramid of doom (https:&#x2F;&#x2F;en.wikipedia.org&#x2F;wiki&#x2F;Pyramid_of_doom_(programming)) and I had been taught this was not a good thing.<p>I&#x27;m happy to code to his particular style, but I can&#x27;t help but feel hurt by the comments. Does anyone have suggestions as to how to separate themselves more from their code&#x2F;work so that I can not take this as personally?

1 comment

wizzwizz4almost 5 years ago
Ask the owner to be a bit nicer. You can say something like:<p>&gt; While we all make snide comments about our own code, it <i>really hurts</i> when it comes from somebody else; this is distracting me from the actual suggestions you&#x27;re giving. Could you try to be nicer with the comments you leave during code review?<p>This isn&#x27;t a problem with you.
评论 #23690736 未加载