TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

JQuery to React: How we rewrote the HelloSign editor

149 pointsby luordover 4 years ago

9 comments

tchaffeeover 4 years ago
We use HelloSign a lot, and it is unreliable. Long waits for pages to load, and sometimes it cannot process a PDF that displays just fine in a variety of viewers. It just hangs with a message to the console every so often saying "Processing document". In our end to end tests Hellosign is often the part that fails, but that will work with enough retries.
评论 #24674131 未加载
评论 #24672584 未加载
评论 #24673793 未加载
jmullover 4 years ago
I think it’s important to note that jquery and react aren’t really the main point in the problem or solution.<p>The problem is they have three things that they want to be the same but aren’t, and the solution is to rewrite so the significant parts can, in fact, be the same. React and jquery are details... that is, you can have the same problem and same solution with different details.<p>I also wonder if this particular approach will end up being successful for them. Can’t the editor, signer and final pdf all be rendered by different browsers and different versions of browsers? IDK, maybe it’s close enough for their cases or there is a strong filter on input that limits this to elements that render consistently enough. Or maybe this is a “must use updated Chrome” app?
评论 #24673585 未加载
评论 #24672834 未加载
clonover 4 years ago
From the article:<p>&gt; A software engineer’s job is not to write code, it’s to solve problems, by writing code when necessary.<p>This is a good litmus test to detect the presence of a senior developer.
评论 #24672852 未加载
评论 #24681583 未加载
veenusavover 4 years ago
Appreciate the effort for writing it. The last section has got an important message.
评论 #24670278 未加载
dominiclover 4 years ago
Having the same implementations on all layers seems like a reasonable approach. But I don&#x27;t see how the choice of the framework helps getting pixel perfect matches especially between different browsers. It seems to me rather the right implementation counts. E.g. using canvas drawing would be one approach to guarantee pixel perfect matches. Also you could do then checksumming in test cases to ensure the images are always the same.
noodlesUKover 4 years ago
I just wanted to say how much I like hellosign as a product, and to keep up the good work! I do wish it were included in my Dropbox subscription though. ;)
评论 #24670403 未加载
babuskovover 4 years ago
&gt; All three components—the Editor, Signer, and completed document—must display accurately<p>Except they don&#x27;t, so the whole blog post should be taken with a grain of salt.<p>I just signed a document a few days ago (on Sept 28th). I didn&#x27;t like the default font for signature they offered, so I picked some other, script type of font. Everything was fine until I saved it. And suddenly, the signature switched to some completely different serif font.<p>The document wasn&#x27;t really that important to me, so I let it go like that, but doesn&#x27;t look like something I would trust currently.<p>EDIT: HelloSign people are obviously reading this. Instead of down-voting me, the proper approach would be to ask for details and fix your bugs. For example, I just tried another document on Windows and it worked properly. For the problematic one, I was using Firefox on macOS, so maybe you should look into that. I can also send you the document ID hash if you ask nice.
评论 #24670653 未加载
评论 #24670421 未加载
评论 #24670527 未加载
lifeisstillgoodover 4 years ago
I assumed that hellosign and it&#x27;s like was about cryptographic &quot;signing&quot; - you know here is a unicode representation of the words you are signing, a hash and ... well probably something using a phones secure enclave<p>I would trust that more than various pdfs ....<p>I assume that&#x27;s just me
评论 #24676190 未加载
baxtrover 4 years ago
Next up: React to Vue
评论 #24679288 未加载
评论 #24671315 未加载