TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Looking for samples of great PR reviews

5 pointsby zach_millerabout 4 years ago
Hey folks, I want to talk to my coworkers about great pull request reviews. I&#x27;d love to see what samples you all might have.<p>Please share links to any great reviews of PRs, especially if the codebase is open source and I can see everything.

2 comments

clusmoreabout 4 years ago
This isn&#x27;t what you asked for, but any time I need to explain to somebody what good code review is, I just tell them to watch this video[0]: &quot;Beyond PEP8 - Best practices for beautiful intelligible code&quot; by Raymond Hettinger.<p>[0]: <a href="https:&#x2F;&#x2F;www.youtube.com&#x2F;watch?v=wf-BqAjZb8M" rel="nofollow">https:&#x2F;&#x2F;www.youtube.com&#x2F;watch?v=wf-BqAjZb8M</a>
muffaabout 4 years ago
Here is some documentation about how google does their reviews. I think it is pretty good <a href="https:&#x2F;&#x2F;github.com&#x2F;google&#x2F;eng-practices&#x2F;blob&#x2F;master&#x2F;review&#x2F;reviewer&#x2F;index.md" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;google&#x2F;eng-practices&#x2F;blob&#x2F;master&#x2F;review&#x2F;r...</a>