TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Those pesky pull request reviews

2 pointsby ifcologneabout 4 years ago

1 comment

datavirtueabout 4 years ago
It&#x27;s for compliance mostly. So whichever regulator sees that you have a code review checkpoint. I look for obvious things like tests with missing edge cases, copy pasta violations, and embarrassing things they missed.<p>If you have static code analysis, automated pipelines, and tests you shouldn&#x27;t be stressed out about code reviews and they should be fast.<p>If I am on good terms with the dev and we have time (LOL) I might try to help them refactor something for clarity.