TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Pull Requests Are an Anti-Pattern

6 pointsby waiganiabout 4 years ago

4 comments

codeapproveabout 4 years ago
I do agree that the process of comitting, pushing, and opening a PR can be a bit clunky. But I also think PRs are super valuable because they encapsulate code and discussion in one place that&#x27;s easy to reference in the future.<p>If I find a line of code that confused me, finding the PR where it happened is often the solution.<p>That said I think GitHub&#x27;s code review tools are lacking and hold us back from doing our best.<p>I&#x27;m building something better at codeapprove.com, if you or your team is interested please email me: sam@habosa.com
TameAntelopeabout 4 years ago
Possibly off-topic, but the &quot;a bug is cheaper to fix the earlier on it&#x27;s discovered&quot; idea came from a since-debunked bit of research, and even if it were true in 1995, has since become untrue through tech advances in how we execute modern deployments, e.g. if I commit a bug in my UI, fixing it in production is the same process as fixing it in dev, just pushing a commit.<p>I wish I had a citation, but my google-fu is getting circumvented by &quot;error&quot; and &quot;cost to fix a bug&quot; being too related.
评论 #26882261 未加载
daanikusabout 4 years ago
The problem isn&#x27;t so much with PRs themselves but the journey up to the PR. If the reviewer has no context of the work, or the author has diverged too much from what was planned, things can quickly get messy with questions and knowledge sharing that should have been done before the code was written in the first place. I don&#x27;t see PRs going away any time soon but they should be treated more as a part of a CI&#x2F;CD pipeline and less as an actual code check.
nhgiangabout 4 years ago
Sounds like the problem is a unit of work is split between too many people, i.e. how the people in the example are using PRs, not PR (as a tool) itself.
评论 #26883514 未加载