TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Send small PRs (Google eng-practices)

25 pointsby amir-hover 3 years ago

3 comments

tharkun__over 3 years ago
I really like this. We try for small PRs as well. Has all of the benefits listed!<p>What they aren&#x27;t good at is to show the overall intent of the whole change. I.e. what I&#x27;ve found is that sometimes an individual PR is easy to review and approve because it seems innocuous and totally fine. But in the overall grand scheme of things I&#x27;d have &quot;questions&quot;. I might even question the overall concept of the whole thing but I don&#x27;t have the full picture and what seems innocent as a small PR is actually going towards a grand vision I can&#x27;t support.<p>I won&#x27;t deny that I&#x27;ve used the same technique to get otherwise probably more controversially discussed stuff through ;)
say_it_as_it_isover 3 years ago
Google ought to spend effort on understanding and then explaining how to chunk large pieces of work that don&#x27;t seem to qualify. Recommending that an engineer asks their peers for help shows that management also has no idea how to chunk the work.
the_arunover 3 years ago
What is a CL?
评论 #28992209 未加载
评论 #28992223 未加载