2/3 of these components are broken on iOS safari. I also see some questionable things happening in the hooks that might not make it past a review.<p>It's a good start, but definitely keep it up.<p>[1] — <a href="https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-intersection-observer.ts#L38">https://github.com/steven-tey/precedent/blob/main/lib/hooks/...</a> (you don't need the ref if you are ignoring exhaustive-deps, not sure why you stringify threshold)<p>[2] - <a href="https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-local-storage.ts#L3">https://github.com/steven-tey/precedent/blob/main/lib/hooks/...</a> (you maybe want to check if a key exists and warn before you set it)<p>[3] - <a href="https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-scroll.ts#L3">https://github.com/steven-tey/precedent/blob/main/lib/hooks/...</a> (you probably want debounce/throttle options here)
Looks cool but im always discouraged by any UI kit that isn't optimized for mobile devices in their demo elements on the front page. Might wanna check the experience on iOS safari ;)
I've checked out the <Modal /> component [1]. What's the reason to go through so many hoops instead of just using the HTML native <dialog> element [2]?<p>[1] <a href="https://github.com/steven-tey/precedent/blob/main/components/shared/modal.tsx">https://github.com/steven-tey/precedent/blob/main/components...</a><p>[2] <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#examples" rel="nofollow">https://developer.mozilla.org/en-US/docs/Web/HTML/Element/di...</a>
I'm waiting for the UI library that also animates everything out that it animates in. I know why people don't do it (it's annoying to do in React), but this gross lack of attention to detail in even the biggest-name software really bothers me. The UX sucks. If you're not going to animate it out, just skip animating it in to at least be consistent!<p>This isn't meant to be a dig at this specific library* (it's certainly no worse than others and you probably did a great job!), but rather the general state of React UI development.<p>*however this library already uses Framer Motion, which makes such things much easier
Curious why you went with RadixUI over HeadlessUI? Not that you shouldn't, just wondering what your decision process was.<p>I also noticed in `_app.tsx` that you wrapped <Component /> in a <main> element. Wouldn't that wrap the entire app within main tags? I think that kind of throws off the normal flow of accessible landmarks.<p>I really like the template so far. Might add a few aspects of it to my own. Thanks for sharing
I think this is pretty neat, my only feedback is that I'd like to see documentation on how to incorporate with an existing or new Next.js project.
Since this is for your and other peoples' new projects, I'd rather recommend you use the app/ in Next 13 rather than pages. I'm told Vercel themselves are doing most new things in app/
I already don't wanna use it when I see api like 'useLocalStorage', when does this end the spreading of this garbage hook thing? What does local storage have anything to do with render cycle?
I love Vercels design, I remember reading on their discussion page that they were working on open-sourcing their components and design system, but that was about two years ago?<p>Now the closest thing we have is geist-ui.dev
I’m already using most of this stack except for Radix, anyone know how it compares to MUI?<p>Surprised they didn’t include a query library. I like the idea of tRPC, but would like to use it on any REST style url.
This seems kinda weird. Random UI components, ORM, and string formatting utilities(???) all part of the same “thing”? I don’t get what this is, seems like a mishmash.