TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

Code reviews should be converging

2 pointsby pdycover 1 year ago

1 comment

nahsraover 1 year ago
&gt; Utilize Automated Tools for Code Style [...]: Ideally, comments related to code convention or commit message convention should not be necessary. These aspects should be checked and corrected via automated tools and made a prerequisite before creating a PR. Let these tools handle consistency, freeing up valuable human review time for more substantive concerns.<p>This is hugely important. Decide on linters, static analysis, refactoring tools, etc., and after a deliberate selection process, never argue about them or their results again. Just make the tools happy and move on.<p>I&#x27;ve also seen high functioning teams choose and agree on an API design philosophy. Arguing about design with no boundaries the discussion feels like arguing about the entire open ocean. Limiting the universe to a small set of design inspiration (kind of like a standard set of UI components) prevents lots of discussion that doesn&#x27;t help the team or the business.<p>For as many things as possible, we should be able to point to something outside of the team, and chosen by the team, and say &quot;this is how we&#x27;ve chosen to do it and we&#x27;re not going to fight about it.&quot;