TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

How We Use Pull Requests To Build GitHub

45 pointsby pathdependentabout 13 years ago

1 comment

bussabout 13 years ago
Pull requests are great, but I think they don't work well for the example that github provides. This use case sucks for reviewers:<p>1. push commits to a branch &#38; open a pull request<p>2. get a bunch of comments<p>3. push a few more commits fixing some errors<p>4. more comments<p>5. more fixes<p>At every step of this process you either have to review each individual commit or the entire diff. You can't see only what's changed between two arbitrary commits. I endure this process so often (and it makes me pine for review board) that I wrote a greasemonkey script to view intermediate diffs: <a href="https://github.com/sbuss/pull_request_intermediate_diffs" rel="nofollow">https://github.com/sbuss/pull_request_intermediate_diffs</a><p>Github, apparently, isn't interested in fixing this (<a href="https://github.com/blog/1124-how-we-use-pull-requests-to-build-github#comment-19295" rel="nofollow">https://github.com/blog/1124-how-we-use-pull-requests-to-bui...</a>)
评论 #3921435 未加载
评论 #3921638 未加载