TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

GitHub comments abused to push malware via Microsoft repo URLs

143 pointsby nateb2022about 1 year ago

9 comments

butterlesstoastabout 1 year ago
I just attempted this myself by creating an issue, commenting a file, copying the link and not submitting the issue.<p>It seems to work initially, but then 5m later the file gets deleted and the link leads to a dead s3 asset page.<p>So I believe this is fixed. Though the solutions suggested below are crafty, trying to reproduce myself shows me this has been addressed by the GH team
评论 #40103019 未加载
评论 #40117465 未加载
lpapezabout 1 year ago
Pretty standard stuff I would say.<p>Back in the day when I worked in this field malware writers regularly used things like Youtube as blob-storage and Instagram comments as C2 server mechanism.<p>Hiding in plain sight can be very effective.
评论 #40099164 未加载
评论 #40098966 未加载
thih9about 1 year ago
This seems simple to fix - deactivate all links that didn’t become part of a published comment.<p>I’m sure this is hard, especially at that scale - then again it seems doable eventually.
评论 #40098735 未加载
评论 #40101403 未加载
评论 #40100234 未加载
评论 #40098839 未加载
评论 #40099108 未加载
Avi-D-coderabout 1 year ago
The obvious fix is to remove the repo information, but do you grandfather in old files by redirecting to the new URL?<p>I’d say no, which I guarantee will break some legitimate packages that depend on files uploaded in GitHub comments.
评论 #40099440 未加载
评论 #40099499 未加载
评论 #40104524 未加载
kevincoxabout 1 year ago
GitHub has githubusercontent.com. Why was this domain not used for these uploads? Or did image uploads in comments predate that domain?<p>But either way putting the repo in the URL seems completely unnecessary. If you need to track ownership you can still do that in the backing database.
评论 #40100259 未加载
评论 #40099800 未加载
Animatsabout 1 year ago
This is yet another example of hosting hostile content on an authoritative site. I still have a service running to track this.[1] It&#x27;s a join of PhishTank and a somewhat dated list of major sites. Google is by far the worst offender. Hosting phishing sites in Google Sheets, etc. is not unusual. Yahoo and Microsoft used to be on that list, but they got better at kicking off hostile content. Adobe (via Adobe Express) has quite a few entries.<p>[1] <a href="http:&#x2F;&#x2F;sitetruth.com&#x2F;reports&#x2F;phishes.html" rel="nofollow">http:&#x2F;&#x2F;sitetruth.com&#x2F;reports&#x2F;phishes.html</a>
ranger_dangerabout 1 year ago
People have also been using the fact that commit data inside of PRs can never be deleted (you must keep the URL though), to distribute pirated content (or links to it) for years now.
评论 #40102663 未加载
ansteabout 1 year ago
File links from comments should just live on a separate page. They should have nothing to do with the repo name or the organization.
cute_boiabout 1 year ago
I think file link shouldn&#x27;t contain repo information like microsoft.