TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

A Philosophy of Code Review

4 pointsby _pastelabout 1 month ago

1 comment

taylodlabout 1 month ago
My thoughts on this approach:<p>- Yes, automate as much as possible. Lint, code formatters, and other analysis tools you may have at your disposable. The team needs to agree on the bar that must be met to submit the PR.<p>- Check the tests. If you&#x27;ve changed something, show me the tests that test that change. Most of my code review is analyzing the quality and coverage of your tests.<p>- I really don&#x27;t care much about your actual code - the automated tools already enforced our coding standards. I&#x27;m not much for coding standards; I&#x27;ll use whatever standard the team wants. I&#x27;m just glad they can be automatically enforced so I don&#x27;t have to engage in pointless arguments that only serve to lower team morale.<p>At the end of the day, I really only care about your tests.