I found a node.js hmac lib on github. Yay.<p>I noticed an open issue requesting express/connect support. I was using express. Perfect, I'll add it. Yay.<p>Submitted a pull request. Yay.<p>My PR was closed without merge. =[<p>The reason included this perl of wisdom along with some others:<p>"Don't leave commented code in a pull request it looks untidy and rushed"<p>Am I crazy?
So? This happens all the time.<p>"I feel like I have to defend my honor here."<p>That's a source of the problem. There's no attack, nor nothing to defend. I see a difference in coding styles. I see that cmawhorter react in a way which does nothing to help the process.<p>If I understand, one of the points of the exchange is that cmawhorter has a peeve against the use of 's === t' while wolfeidau prefers that style. Douglas Crockford, of course, suggests using '===', and it's perfectly acceptable for wolfeidau to require that of any contributed code. That cmawhorter reacts so strongly to others who don't share this peeve disagree suggests that cmawhorter may not be an appropriate collaborator for wolfeidau.<p>"working with me into making this something you find acceptable"<p>It is not a reasonable to assume that others are obliged to work with a pull request submitter.