TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

The problem with pull requests / code reviews

19 pointsby philfreoabout 12 years ago

4 comments

peter_l_downsabout 12 years ago
If you're interesting in an alternative, I highly recommend Phabricator [0], a fantastic suite of tools that came out of Facebook. It has all sorts of random modules (memegen equivalents, etc.) but it has a really great feature tracker and a really great code review tool. Addressing your particular issue, it also shows the output of git diff, but includes buttons for '20 more lines of context' at the top and bottom of the diff [1].<p>Also, Evan Priestly (the lead contributor) responds immediately to any sort of issue and the source is readable. My workplace hosts our own, but I think there may be a hosted version available, too.<p>[0] <a href="http://phabricator.org/" rel="nofollow">http://phabricator.org/</a> [1] <a href="http://imgur.com/BK55AKF" rel="nofollow">http://imgur.com/BK55AKF</a>
评论 #5636834 未加载
评论 #5636775 未加载
DanielRibeiroabout 12 years ago
My biggest issue with pull requests was lack of syntax highlight. I managed to fix that though[1]. It would be nice to have it as a native feature though.<p>[1] <a href="https://github.com/danielribeiro/github-diff-highlight#github-diff-highlight" rel="nofollow">https://github.com/danielribeiro/github-diff-highlight#githu...</a>
philfreoabout 12 years ago
Someone pointed out that Bitbucket actually already has my "click '...' to expand" idea. Might be nicer with an animation, or if they started loading the AJAX request upon hover instead of click since it takes a while, but overall works well.
birkenabout 12 years ago
At Thumbtack we use Github for our source control, but not our code review. We use rietveld -- <a href="https://code.google.com/p/rietveld/" rel="nofollow">https://code.google.com/p/rietveld/</a>, which is an open source code review tool made to be similar to Google's internal code review tool, Mondrain.<p>It has a much better view of the diff, incorporating much more context and a side-by-side view (here is a example change I just randomly pulled from rietveld's internal rietveld: <a href="https://codereview.appspot.com/8726052/diff/1/pom.xml" rel="nofollow">https://codereview.appspot.com/8726052/diff/1/pom.xml</a>). It also has the ability to group multiple in-line comments together in chunks, so it is apparent to coworkers when one round of the code review is done and they should work on it and get it back to you. It also has tons of other great features (email integration, keyboard shortcuts for moving around the code, etc etc).<p>Of course, you can only use this if you control a project, and you will have to do a little integration work, but if code review is an important part of your team's workflow, I highly recommend the investment.