This looks nice, but doesn't address my main complaint with the conversation/PR system: there's no way to batch comments.<p>When doing code reviews, you can sometimes have upwards of 10 or 15 comments. In the current system this means 10 or 15 emails in everybody's inbox. It's also hard to work through a PR without letting everybody know when you're actually finished.<p>I would love to be able to comment on things as I read through them, then after I finish publish all of the changes and have them go out as one email.
So I use github enterprise and use the review tool a lot.<p>It has improved our overall code review experience, but there is a few things which have proved problematic and even have caused major headaches in the last year or so.<p>1. No Side by Side diffs.
2. Pushing new commits will often collapse conversations from the review. (i.e these conversations are folded)<p>Really, I want some way to look at my PR and say hey I've addressed all the comments on this pull request, and I am good to merge.<p>This is not even getting into what happens if you rebase your branch and then force a push to the remote.
This is a good redesign but I wish they put more focus on developing Github Issues. The back button doesn't work (old issues randomly show) and filtering needs work (for example, how can I show issues from two milestones? how about showing issues with no comments? etc.).
Am I the only one who dislikes that they made all the fonts slightly larger? I'm working on a 1080p monitor atm and I really don't want more screen real estate taken up with no benefit.
The other thing I'd like to see is context on emails in a conversation thread. So if I reply to a comment you've made, it would be great to see the comment I'm replying to IN the email itself (or at the very least, the last comment on that line, if there are multiple comments).<p>A lot of times I'll get an email comment and have no idea what they're talking about till I click through to go back to the conversation thread
Overall, I like what I'm seeing so far. The notable exception is that they removed the build status indicator for Pull Requests from the PR body and now only show the faint green check next to a commit hash. Makes determining whether a PR is good to merge a bit more difficult IMHO. Hopefully that gets fixed.
Do you guys think the headline in the example,<p>" Upgrade to Normalize v3 #12406
Merged mdo merged 5 commits into master from normalize_v3 about 4 hours ago "<p>occupy too many space in the web page?