TE
TechEcho
Home24h TopNewestBestAskShowJobs
GitHubTwitter
Home

TechEcho

A tech news platform built with Next.js, providing global tech news and discussions.

GitHubTwitter

Home

HomeNewestBestAskShowJobs

Resources

HackerNews APIOriginal HackerNewsNext.js

© 2025 TechEcho. All rights reserved.

A reminder to be cautious merging pull requests on NYE

7 pointsby everettForthover 10 years ago

1 comment

mc_hammerover 10 years ago
Im not saying its even 50% true but the original comitters recent commits look almost-suspect too.<p>a few things that look guilty even though they might not be:<p>(just looking at 5 of his last 1 mo of commits)<p>1) hes touching a lot of crypto 2) hes removing crypto 3) hes adding ifdefs disabling services (ie #ifdef windowsstuffflag skip_eliptic_curve_encryption ) - real example . wtf. 4) im not seeing a lot of feature additions 5) oh openssl 1.0 came out i better make 1.01 2 days later with like 2 features, my tls heartbeat code and some lame other feature 6) his heartbleed commit uses the var &quot;payload&quot; instead of &quot;data&quot; or &quot;msg&quot; - wtf.<p>7) hes reversing flags in code<p><pre><code> if (&quot;OK&quot; == vt_asdf_ok){ if (checkflags) { dostuff() </code></pre> becomes<p><pre><code> if (&quot;ok&quot; != vt_Asdf_ok) { } if (!checkflags) { &#x2F;&#x2F;dostuff </code></pre> idk i only looked at 5 commits