TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Ask HN: Can someone please review my code?

1 点作者 saq7将近 9 年前
I recently did a work sample in Rails for a company which I will not name. I felt pretty good about it when submitting it, but I was ultimately rejected. They did not provide any feedback because they wanted to keep the hiring process under wraps, and I respect that. The problem still remains that I have no idea what I did wrong or what I need to do to improve.<p>So I want to ask you to review the code and let me know what you think. I will not post this work on a public site, because I want to respect the wishes of the company.<p>So my idea is to post it on bitbucket in a private repo and if you wish to review it, I will add you to the repo. I understand this is a lot to ask for when asking for feedback on the internet, and if there is a more straight forward way I have overlooked, please let me know.<p>My goal here is to understand what I did wrong and improve while still respecting the wish for secrecy by the original company.<p>Thanks a lot in advance<p>[edit]<p>I posted this request here and on reddit and I got same feedback - post the code on github. So I have done so. It can be found here https:&#x2F;&#x2F;github.com&#x2F;saq7&#x2F;rails-work-sample&#x2F;

4 条评论

mtmail将近 9 年前
The changes probably solved the feature request(s) and it looks Rails-like and a lot of engineers would&#x27;ve coded in the same style.<p>Reading the instructions (<i>), especially<p>&quot;Your presentation should be something you&#x27;re proud of. The user-experience and aesthetic aspects should be well considered.&quot;<p>I&#x27;d say they were looking for candidates who simply spend more time on the project. More CSS changes, more refactoring, maybe giving them a list of things you wish you had time to solve.<p>Entirely possible it&#x27;s not code related at all. Them waiting for another candidate, somebody impressed them more for non-technical&#x2F;coding reasons, hiring freeze the manager doesn&#x27;t want to admit or internal discussions about the job role.<p>All you can do is send a nice email asking for feedback. If they don&#x27;t provide that, move on.<p></i>) Took just 2 clicks to see the deleted files. It&#x27;s possible to delete files from repositories including history.
评论 #12023309 未加载
based2将近 9 年前
<a href="https:&#x2F;&#x2F;www.reddit.com&#x2F;r&#x2F;codereview&#x2F;" rel="nofollow">https:&#x2F;&#x2F;www.reddit.com&#x2F;r&#x2F;codereview&#x2F;</a>
dudul将近 9 年前
You seem to care a lot about the &quot;feelz&quot; of a company that rejected you without providing any feedback to help you improve. Just post the thing on github (or public bitbucket) and paste a link here. Unless you signed a NDA regarding their hiring process, you don&#x27;t owe them anything at this point.
评论 #12011335 未加载
sharemywin将近 9 年前
Did you use any of this crap? if not your code probably wasn&#x27;t hip enough.<p><a href="http:&#x2F;&#x2F;code.tutsplus.com&#x2F;tutorials&#x2F;ruby-on-rails-study-guide-blocks-procs-and-lambdas--net-29811" rel="nofollow">http:&#x2F;&#x2F;code.tutsplus.com&#x2F;tutorials&#x2F;ruby-on-rails-study-guide...</a>
评论 #12011225 未加载