TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Introducing review requests

54 点作者 jglovier超过 8 年前

4 条评论

gkop超过 8 年前
Has GitHub improved reviews since launch? I tried the review feature at launch and found it to be a severe regression from plain PR inline comments, because the review comments weren&#x27;t hidden when the code they referenced changed, so I had to manually check each review comment to see whether or not it was addressed by a follow-on commit. I emailed their support asking if I was using the review feature wrong, and they said No, I was using it correctly, and it was a known weakness in the feature that they were tracking.<p>Review requests are useless until GitHub makes the reviews themselves useful.
评论 #13127466 未加载
评论 #13127210 未加载
Kubuxu超过 8 年前
Being able to search for things my review is requested on would be good companion feature for it.
评论 #13127339 未加载
donatj超过 8 年前
Kind of interesting. What I&#x27;d really like to be able to do is <i>require</i> specific people to review before merging, for example require a review by at least one of our senior developers.<p>Right now the greenest guy on the team can approve a PR and it can be merged.<p>The real dream would be to be able to set the requirements on a per-directory basis, but I doubt that would ever happen.
评论 #13127451 未加载
评论 #13127116 未加载
评论 #13127303 未加载
评论 #13126973 未加载
whyrusleeping超过 8 年前
Are there any api endpoints now for querying reviews? I&#x27;d love to have a way to get a list of reviews i&#x27;m being asked to do.
评论 #13127546 未加载