TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Torvalds: I've pulled this, but if problems, ext4 is going on my shit-list

98 点作者 torvald将近 8 年前

8 条评论

tytso将近 8 年前
I&#x27;ll admit the pull request was a little marginal for patches that would be landing in -rc4, which is roughly halfway through the development cycle. That being said, all of the patches got independent review (none of them were authored by me, and I reviewed them all before accepting them). I also ran the tests through a very extensive regression test suite. (<a href="https:&#x2F;&#x2F;thunk.org&#x2F;gce-xfstests" rel="nofollow">https:&#x2F;&#x2F;thunk.org&#x2F;gce-xfstests</a>). So even though many of the commits landed very recently, in my experience testing catches many more problems than end user testing in linux-next, because not that many people run linux-next.<p>Granted, I certainly wouldn&#x27;t have sent this pull request any later. After rc4 the only thing I would send are regression fixes, and at most one commit in this pull request could be considered a regression fixes. The last commit listed in the short log &quot;make xattr inode reads faster&quot; optimizes a new feature (large xattr support) that only landed in this merge window. So it&#x27;s not going to have many users, and I figured it was safe.<p>Cleanups have always been in the grey area. I certainly wouldn&#x27;t have any hesitation sending these cleanups a week or two earlier. None of them were terribly large by themselves, although as a whole it&#x27;s a somewhat large merge request for at this point in the cycle:<p>13 files changed, 290 insertions(+), 196 deletions(-)<p>If I screwed up, and missed a bug in my code review, and it wasn&#x27;t picked up in the testing, ultimately I&#x27;m the one that&#x27;s going to be held accountable. Which presumably means that Linus isn&#x27;t going to be trust me in the future when I send in another marginal pull request.<p>In the past, when I was ultra-conservative and wouldn&#x27;t send any of these fixes until the merge window, Greg K-H would sometimes grump at me because it would delay the fixes getting to stable kernel, and it would also contribute towards making his workload more &quot;lumpy&quot;. What I would have done after -rc4 (and perhaps what I should have done for -rc4) is to only push those fixes that were cc&#x27;ed to stable@vger.kernel.org or were specifically regression fixes.<p>Bottom line: I did realize that what I was sending to Linus was pushing the boundaries a bit. And Linus was making sure that I knew that.
评论 #14944243 未加载
评论 #14945507 未加载
taeric将近 8 年前
This seems a prime example of Linus being a pretty awesome maintainer. Blunt, but really just honest on messaging.<p>Or was I supposed to read this differently?
评论 #14943769 未加载
odammit将近 8 年前
Every post I see on HM about Linus is about how cool it is that LT is an asshole.<p>What&#x27;s with the skewed asshole-bias? Same people will bitch about &quot;asshole people&quot; on there own teams that are tough on PRs.
评论 #14944055 未加载
评论 #14943889 未加载
评论 #14944556 未加载
lorey将近 8 年前
Could someone please give some context on this?
评论 #14943677 未加载
评论 #14943625 未加载
评论 #14943634 未加载
moron4hire将近 8 年前
It always cracks me up how Torvald&#x27;s &quot;necessary, blunt honesty&quot; is so frequently more verbose than a neutral, not-rude answer would have been.
评论 #14943850 未加载
achtung666将近 8 年前
BREAKING NEWS: Linus used word &quot;shit&quot; on email message.<p>Geez, srsly...
mmel将近 8 年前
This is not noteworthy.
sexydefinesher将近 8 年前
St Ignucius bless his heart