TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Go accepts patches from GitHub pull requests now

277 点作者 vhost-超过 7 年前

6 条评论

bradfitz超过 7 年前
To summarize:<p>We now mirror GitHub PRs into Gerrit. Gerrit is still our upstream Git server. Gerrit is still where we do reviews and press the &quot;Merge&quot; button. (And once merged, it gets mirrored back to GitHub)<p>But now we have a bot that slurps PRs into Gerrit and syncs comments back and forth and closes PRs when needed. (We&#x27;ll do more fine-grained comment sync in the future. We just shipped an &quot;MVP&quot; for the Go 1.11 tree opening).<p>Some more information is at <a href="https:&#x2F;&#x2F;golang.org&#x2F;wiki&#x2F;GerritBot" rel="nofollow">https:&#x2F;&#x2F;golang.org&#x2F;wiki&#x2F;GerritBot</a><p>Code is at <a href="https:&#x2F;&#x2F;github.com&#x2F;golang&#x2F;build&#x2F;blob&#x2F;master&#x2F;cmd&#x2F;gerritbot&#x2F;gerritbot.go" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;golang&#x2F;build&#x2F;blob&#x2F;master&#x2F;cmd&#x2F;gerritbot&#x2F;ge...</a>
评论 #16364061 未加载
评论 #16364925 未加载
tejasmanohar超过 7 年前
This is an excellent change. While Gerrit is undoubtedly more powerful than GitHub&#x27;s PR, GitHub is easy and familiar. I&#x27;ve found a fair number of small fixes and changes I&#x27;ve wanted to make to Gerrit projects but just abandoned due to not being inline with my current workflow. Now, I&#x27;ll submit a PR and figure out the rest later. Hopefully, code review still being through Gerrit doesn&#x27;t mean more stale PRs to deal with though. I guess time will tell...
tombh超过 7 年前
It seems odd to me that Golang treats Github as a first class citizen for package management, yet a second class citizen for core contributions.<p>I&#x27;m really only a dabbler in Golang, so would appreciate any context.<p>For instance I was affected by the recent go-bindata owner change[1]. The Github user deleted their account and some random user reregistered the original user&#x27;s name and recreated the repo (albeit seemingly innocently to help everyone get their CIs running again).<p>Actually while we&#x27;re on the subject, Golang&#x27;s whole package management experience is surprisingly disappointing :&#x2F;<p>[1]<a href="https:&#x2F;&#x2F;www.reddit.com&#x2F;r&#x2F;golang&#x2F;comments&#x2F;7vv9zz&#x2F;popular_lib_gobindata_removed_from_github_or_why&#x2F;" rel="nofollow">https:&#x2F;&#x2F;www.reddit.com&#x2F;r&#x2F;golang&#x2F;comments&#x2F;7vv9zz&#x2F;popular_lib_...</a>
评论 #16364773 未加载
评论 #16365068 未加载
评论 #16367492 未加载
nbsd4lyfe大约 7 年前
I&#x27;m still putting off contributions because the CLA signing mechanism asked me for my phone number.
mgbmtl大约 7 年前
Slightly off topic, but would anyone have a similar solution&#x2F;experience to sync between GitHub and Gitlab? (community version, not EE, since this is for a Free Software project)
评论 #16369375 未加载
shabbyrobe大约 7 年前
Great to see the high-friction barriers falling. The move to Github for issues has been a massive improvement.<p>Hopefully they can do something about getting rid of Google groups now. It&#x27;s an extraordinarily poor organ of record. The low-friction Github issue tracker is full to bursting with high-ranking results for things that amount to support requests, but the pat response is a slightly-too-curt &quot;ask this on golang-nuts, closed, kthxbye&quot;, and that&#x27;s where the trail ends.
评论 #16382640 未加载