TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Ask HN: Styling comments in PR reviews

3 点作者 navalsaini将近 7 年前
I get a lot of styling comments in my PR reviews (like gnats on a in a PR jungle :-p). This is in Typescipt. TBH I don&#x27;t find working on them the best use of time a lot of times.<p>Is it common for one or two people on a team to receive a lot of styling comments? I am pretty sure this is a good mix of product focussed and pure software engineering focussed groups.<p>Drop a paragraph on what story or insight comes to your mind on the subject.

3 条评论

fardo将近 7 年前
Usually it’s one of three things:<p>&gt;Your style isn’t up to spec<p>If you always smell crap, check the bottom of your shoes. I’ve found team style guides to be useless generally, but attempting to emulate team style by looking at existing code is a winning move. Coding is a team effort, and even if it’s a little extra work, a little beautification can go a long way towards readability.<p>&gt;Code reviewers want or are incentivized to help<p>Many code reviewers make a point not to leave a nontrivial review without commenting. Whether this is because they want to help, or because in many workplaces, the code review metric optimized for is “comments closed”, some people will feel obligated. When there’s no substance to dissect, style is often substituted<p>&gt;Someone’s giving you a hard time for irrational reasons<p>This is an interpersonal issue. You don’t, in my opinion, need to worry how others will view you if this happens since most people can tell when somebody is just being a dick in a CR. If you’re concerned about this, try to figure out why you two have beef by asking them and either resolve it, ignore&#x2F;forgive it and move on (some hills aren’t worth dying on), involve management or HR, or change roles
评论 #17582986 未加载
sloaken将近 7 年前
Some people need to comment on something in order toi justify their existance. Subjective issues are the easiest.<p>I assume PR is not public relations?<p>&lt;story&gt; Long time ago I worked at this place where the CEO was known for needed to fel involved without actually being involved. My boss had me work on a demo that the CEO would use for potenial clients. In the middle of the demo it did some odd steps. Clearly a mistake, I had just failed to remove a part in the scripting. Well I showed this to my boss, with the odd part in, since I did not realize it was there. When it happened I commented that I obviously need to remove that part. He told me to leave it in, as it would give the CEO something to complain about, and feel like he had made a real contribution. When shown to the CEO he loved the presentation except for that one glitch. You could almost read his mind (&quot;oh my what would these foolish developers do without me&quot;). &lt;story off&gt;<p>Sadly I have seen this repeated many times.
评论 #17582995 未加载
spicyj将近 7 年前
Use Prettier and never look back.
评论 #17583048 未加载