TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

How to Do Code Reviews

56 点作者 kevination超过 5 年前

7 条评论

pc86超过 5 年前
The title of the article is &quot;How to do code reviews&quot; yet all the content is around why code reviews are done and what the goals are. And the content itself is pretty light - the second half is just rehashing the first half, which are all bullet points.<p>I&#x27;m curious how it made it to the front page and if some of the folks who thought it was useful could comment about how it helped them understand <i>how</i> to do a code review?
评论 #22141670 未加载
评论 #22142556 未加载
评论 #22141268 未加载
评论 #22141240 未加载
jmull超过 5 年前
This is a nice check-list.<p>A lot of people don&#x27;t really know this stuff. It&#x27;s nice to have a concise page to point them to.
kevsim超过 5 年前
Nice list but for me missing the most difficult pieces<p>- while giving a review, how to not focus on superficial details but instead really take the time to understand the problem and the solution. Making sure you can really understand why things were done the way they were and thinking about whether things could be made more clear, performant, follow best practices more closely, etc<p>- when receiving a review learning that people are reviewing it your code not you, learning how to look forward to reviews because they make your final product better<p>Would love to see advice on the really difficult bits of code review
评论 #22141617 未加载
arminiusreturns超过 5 年前
The article is more why than how, so I have a question for HN. Is it acceptable for a company to not do code review until late in the funding game (like series E&#x2F;F)? Like move fast and break things to get MVP going and break a lot of best practices doing it, and at what point should that be reigned in?<p>Imagine you are at a unicorn with physical product already operating in public, and a C laughs at a suggestion of code review and says its too long, hard and expensive. What would you do?
solidist超过 5 年前
Good post on the what.<p>This one on the human&#x2F;how: <a href="https:&#x2F;&#x2F;dev.to&#x2F;solidi&#x2F;be-a-rockstar-at-pull-requests-1e4f" rel="nofollow">https:&#x2F;&#x2F;dev.to&#x2F;solidi&#x2F;be-a-rockstar-at-pull-requests-1e4f</a>
revel超过 5 年前
This is more of a list of &quot;why&quot; you do code reviews rather than how to do them. In my opinion the way to do code reviews is to be didactic. The point is not <i>just</i> to tell people that there are problems, but to explain why they are problems so that the developer can learn and avoid making similar problems in the future.
评论 #22141296 未加载
Zolomon超过 5 年前
Steals&#x2F;Hijacks the back-button via option-left keys, which was quite unexpected.