TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

Vuejs rejects close to 75% of outside contributions

90 点作者 gieksosz超过 4 年前

12 条评论

Xevi超过 4 年前
That&#x27;s the old Vue 2 repository, which has been pretty inactive for a while due to the full rewrite of Vue.<p>Vue 3 (70.62% acceptance): <a href="https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=vuejs&#x2F;vue-next" rel="nofollow">https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=vuejs&#x2F;vue-next</a><p>Svelte (57.23% acceptance): <a href="https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=sveltejs&#x2F;svelte" rel="nofollow">https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=sveltejs&#x2F;svelte</a><p>React (45.99% acceptance): <a href="https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=facebook&#x2F;react" rel="nofollow">https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=facebook&#x2F;react</a><p>Angular (1.63% acceptance): <a href="https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=angular&#x2F;angular" rel="nofollow">https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=angular&#x2F;angular</a>
评论 #25725382 未加载
zinekeller超过 4 年前
I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons).<p>In my personal experience, the acceptance rates doesn&#x27;t really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really <i>discourages</i> direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead relying on bug reports instead. SQLite however <i>is a very good product</i>, something that I personally miss when I work on JS projects.<p>On the other hand, I&#x27;ve seen projects (multiple, which I prefer not naming to prevent flame wars) with very high acceptance rates - the problem is that the coding style and availability of comments are inconsistent to the point that we have to forego using some libraries and writing our own despite those libraries will fit into the bill nicely.<p>Edit: some have commented &quot;this is what I&#x27;ve expected!&quot;, but there are some projects (obviously will be unnamed) that are not accepting contributions but the code consistency is less-than-ideal, and some projects with well-behaved outside contributors that have kept the quality despite having high acceptance rates (usually writing in relatively niche languages). Probably the area I&#x27;m working on (educational) isn&#x27;t reflective on the wider community, which seems to associate higher rejection rates to quality.
评论 #25719821 未加载
评论 #25719901 未加载
评论 #25719706 未加载
评论 #25719774 未加载
spartanatreyu超过 4 年前
This is for the old version of vue (v2), not the current vue (v3).<p>This title should read: Vue accepts 70% of outside contributions on latest version and only 23% on old version.
评论 #25719775 未加载
评论 #25719534 未加载
BugsJustFindMe超过 4 年前
Looking at the PR history for the vuejs repo, I can&#x27;t say that I&#x27;m surprised. Holy hell, what a wasteland.
评论 #25719372 未加载
评论 #25719389 未加载
评论 #25719328 未加载
评论 #25719894 未加载
thih9超过 4 年前
I wish the submitter added their comment or gave some context, if there is any. For me this is an arbitrary number for a random popular repository. Especially since the linked github project <a href="https:&#x2F;&#x2F;github.com&#x2F;vuejs&#x2F;vue" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;vuejs&#x2F;vue</a> is not the latest version of vue (see: <a href="https:&#x2F;&#x2F;github.com&#x2F;vuejs&#x2F;vue-next" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;vuejs&#x2F;vue-next</a> ).
评论 #25719954 未加载
captain_price7超过 4 年前
Maybe significantly more work, but can you try to filter out very small (or spam) PRs before these calculations? Maybe limit this analysis to PRs that edits source code (not just comment and docs). Or maybe include those, but only when &quot;amount&quot; of changes cross a certain threshold? (e.g. exclude PRs that fix just one typo)
评论 #25725893 未加载
zX41ZdbW超过 4 年前
You can obtain this data for all existing repositories by one request in one second:<p><a href="https:&#x2F;&#x2F;gh-api.clickhouse.tech&#x2F;play?user=play#U0VMRUNUCiAgICByZXBvX25hbWUsIAogICAgdW5pcShhY3Rvcl9sb2dpbiksIAogICAgdW5pcShudW1iZXIpLCAKICAgIHN1bShtZXJnZWQpLCAKICAgIHJvdW5kKHN1bShtZXJnZWQpIC8gdW5pcShudW1iZXIpICogMTAwKSBBUyBwZXJjZW50IApGUk9NIGdpdGh1Yl9ldmVudHMgCldIRVJFIGNyZWF0ZWRfYXQgPj0gdG9kYXkoKSAtIElOVEVSVkFMIDkwIERBWSAKICAgIEFORCBldmVudF90eXBlID0gJ1B1bGxSZXF1ZXN0RXZlbnQnIApHUk9VUCBCWSByZXBvX25hbWUgCk9SREVSIEJZIHVuaXEoYWN0b3JfbG9naW4pIERFU0M=" rel="nofollow">https:&#x2F;&#x2F;gh-api.clickhouse.tech&#x2F;play?user=play#U0VMRUNUCiAgIC...</a>
评论 #25725897 未加载
jdieiueejjene超过 4 年前
The best part about Vue is it isn’t sponsored by giant evil corporation like Facebook who have enabled violence and racism for the past 4 years.<p>We as developers need to do better and support people like Evan out there.<p>Eventually, we should also hold individual engineers who work at Facebook&#x2F;similar accountable to a higher standard and reject their software even if it’s open source or wonderful (React).
评论 #25719598 未加载
评论 #25723629 未加载
zhirzh超过 4 年前
not sure if there&#x27;s a point to checking this stat this is interesting, though checkout vim. it has 0% acceptance: <a href="https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=vim&#x2F;vim" rel="nofollow">https:&#x2F;&#x2F;merge-chance.info&#x2F;target?repo=vim&#x2F;vim</a>
评论 #25722740 未加载
mlthoughts2018超过 4 年前
I think this is a good thing generally, Vue has consistently been one of the best engineered and most effectively designed pieces of software in the Javascript world, largely due to uncompromising enforcement of the design opinions and aesthetics it asserts.<p>As long as the maintainers are responsive to bug fixes and key feature requirements (since they aren’t accepting of outside contributors adding them), then this is fine, possibly even optimal in terms of quality.<p>The trouble comes in if they both don’t allow many outside contributions and at the same time they pull the same unjustified complaint of a lot of OSS and say because they aren’t paid for their time, they will prioritize what interests them rather than what resolves painpoints or missing features users need. You definitely can’t have it both ways.
评论 #25719489 未加载
评论 #25719761 未加载
评论 #25719456 未加载
notretarded超过 4 年前
Ahhh the applying Torvalds approach to code reviews.
zoobab超过 4 年前
As long as you can play Doom.