WebKit Quirks

196 点作者 momonga超过 4 年前

18 条评论

tholman超过 4 年前

If I'm understanding L958+ [1] There's a hyper specific css class browser quirk because the login button for gizmodo/kotaku/etc's CMS's svg icon click event wasn't firing... and here I am fixing my day-to-day browser bugs like a chump[1] <a href="https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/Quirks.cpp#L958" rel="nofollow">https://github.com/WebKit/WebKit/blob/main/Source/WebCore/pa...</a>

matsemann超过 4 年前

<pre><code> shouldBypassBackForwardCache() // Google Docs used to bypass the back/forward cache by serving "Cache-Control: no-store" over HTTPS. // We started caching such content in r250437 but the Google Docs index page unfortunately is not currently compatible // because it puts an overlay (with class "docs-homescreen-freeze-el-full") over the page when navigating away and fails // to remove it when coming back from the back/forward cache </code></pre> Millions of pages have this bug, because of Safari's broken navigation. Nice that the big players get the browser to fix it for them. For instance, a common issue is you click a button that becomes disabled and shows a spinner while working, before forwarding to a new page. If you click back from the new page, Safari will render the previous page exactly as it was when leaving, so in a broken loading state (instead of starting it from scratch).

评论 #26167355 未加载

评论 #26166057 未加载

评论 #26167731 未加载

评论 #26168399 未加载

jakub_g超过 4 年前

There was a viral tongue-in-cheek tweet this month "how to prevent scrolling in Safari when..."?1. Buy Zillow. Destroy the company.2. Redirect your website to zillow.com(it was more fun that what I wrote)<a href="https://github.com/WebKit/WebKit/blob/f43587ec2416b86eecef5091fe028a08e168f976/Source/WebCore/page/Quirks.cpp#L703-L709" rel="nofollow">https://github.com/WebKit/WebKit/blob/f43587ec2416b86eecef50...</a>

TonyTrapp超过 4 年前

I really dislike this sort of quirk workarounds, not just in web browsers. It just makes everything complicated. Someone else using the exact same code will get different behaviour, just because they serve it from a different domain. I did similar workarounds before (not related to websites but to specific files), and I felt very bad about it even though it was clear that no more files in that specific format would ever be generated again.

duckerude超过 4 年前

> domain.endsWith("hulu.com")Huh, does that mean it would also apply on "thisisnothulu.com"?Most other endsWith calls seem to do e.g. `domain.endsWith(".hulu.com")` to only match subdomains.

评论 #26168342 未加载

评论 #26173807 未加载

评论 #26186016 未加载

评论 #26166983 未加载

评论 #26171607 未加载

0x0超过 4 年前

I bet it's fun being responsible for developing and deploying on those sites. Works in CI and dev, but deploying to production makes the browser behave differently! Nice surprise!

评论 #26166531 未加载

firloop超过 4 年前

Wow, there's not only _domain_ specificity, but also HTML _element_ specificity in this quirks list.<pre><code> // When panning on an Amazon product image, we're either touching on the #magnifierLens element // or its previous sibling. auto& element = downcast<Element>(*target); if (element.getIdAttribute() == "magnifierLens") return true; if (auto* sibling = element.nextElementSibling()) return sibling->getIdAttribute() == "magnifierLens"; </code></pre> <a href="https://github.com/WebKit/WebKit/blob/3def0062f77b82a46fc40c7154098b5fc0f12db9/Source/WebCore/page/Quirks.cpp#L416-L422" rel="nofollow">https://github.com/WebKit/WebKit/blob/3def0062f77b82a46fc40c...</a>

评论 #26172121 未加载

kgin超过 4 年前

It's like that saying about debt.When a browser renders your 500 mau site badly it's your problem.When a browser renders your 50,000,000 mau site badly it's the browser's problem.

IMTDb超过 4 年前

That's new "you have made it when"...they need to change the browser engine for your website.

评论 #26170144 未加载

sdflhasjd超过 4 年前

Domain name specific quirks?What in the world...

评论 #26165631 未加载

评论 #26167992 未加载

评论 #26167436 未加载

评论 #26165679 未加载

TazeTSchnitzel超过 4 年前

Anyone who's read a few Old New Thing posts would know that Windows must be full of similar checks.

评论 #26166582 未加载

评论 #26171946 未加载

throwaway744678超过 4 年前

Wow, there's a nice 77 characters function name [1]! Yes, with a typo. Hard to keep the lines under 80 characters...[1] <a href="https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/Quirks.cpp#L265" rel="nofollow">https://github.com/WebKit/WebKit/blob/main/Source/WebCore/pa...</a>

评论 #26169070 未加载

shadowgovt超过 4 年前

The thing about network effects is this:When you're making a new technology to interact with existing technology, and following the specification results in your new technology failing to work with what's already there, nobody will care if you blame the standard or everyone's mis-implementation of the standard.They'll consider your malfunctioning tool as damage and route around it... Until you become big enough that you can be the existing implementation other people have to adapt to.Every commonly-used browser either has something like this buried in its implementation or has a date-stamp of first release older than everything else out there.

saagarjha超过 4 年前

It's fun (and a little depressing) to look at this list, but it exists is basically every popular project. Unfortunately, the incentives are set up for this to essentially be necessary: if something popular doesn't work in your software, users are going to think your code is the one who is broken, not the thing they are trying to use. So you have a sort of a "tragedy of the commons" where if you keep a principled position a user is going to switch to your competitor that supports quirks to get the thing to work.

jaywalk超过 4 年前

Interesting to see www.icloud.com in there...

spectramax超过 4 年前

We need something new here. This is not scalable. If a group of engineers can't write a new browser in sabbatical, then we need to change what a browser (and the spec) should be.Access to internet should be simple, not complicated so many can participate and leave control out of big corp.

tabtab超过 4 年前

Web UI "standards" are a friggen mess. We really need to rethink it all. For one, if we had a standard state-ful GUI markup language, we wouldn't need to reinvent so many common GUI widgets and idioms using bloated libraries based on JS + DOM.Second, if web standards allowed true absolute positioning of vectors (as an option), then the layout engines could reside on servers, allowing us to choose a layout engine that best fits domain and need.Note that while existing web standards do have some coordinate based features, they are too inconsistent to reply upon. If they were any good, we wouldn't need PDF viewers.

评论 #26172971 未加载

lxe超过 4 年前

Wow, this is terrible. Either fix the bugs, introduce non-standard behavior for all sites, or expect these big players to fix their own problems.

评论 #26172909 未加载