A data corruption bug in OpenZFS?

IMO, part of the issue is that something which used to be just a low-level optimization (don&#x27;t store large sequences of zeros) became visible to userspace (SEEK_HOLE and friends). Quoting from this article:<p>&quot;This is allowed; its always safe to say there’s data where there’s a hole, because reading a hole area will always find “zeroes”, which is valid data.&quot;<p>But I recall reading elsewhere a discussion about some userspace program which did depend on holes being present in the filesystem as actual holes (visible to SEEK_HOLE and so on) and not as runs of zeros.<p>Combined with the holes being restricted to specific alignments and sizes, this means that the underlying &quot;sequence of fixed-size blocks&quot; implementation is leaking too much over the abstract &quot;stream of bytes&quot; representation we&#x27;re more used to. Perhaps it might be time to rethink our filesystem abstractions?

When I think of a fs corruption bug, I think of something that causes fsck&#x2F;scrub to have some work to do, sometimes sending resulting in restore from backups. From the early reports of this, I was having a hard time understanding how it was a corruption bug. This excellent write up clears that up:<p>&gt; Incidentally, that’s why this isn’t “corruption” in the traditional sense (and why a scrub doesn’t find it): no data was lost. cp didn’t read data that was there, and it wrote some zeroes which OpenZFS safely stored.

Fascinating write up. As someone with a ZFS system, how can I check if I’m affected?

It&#x27;s important to note that the recent showstopper bugs have all been in OpenZFS, with the Oracle nee Sun ZFS being unaffected by either.

I wonder if any large storage provider has been affected by this. I know Hetzner Storage Box and rsync.net both use ZFS under the hood.

anyone know what diagram tool did he use? thanks

Excellent writeup robn!

Is anybody using bcachefs yet?

Periodic reminder to check if your backups are working, and if you can also restore them. It doesn&#x27;t matter which file system or operating system you use, make sure to backup your stuff. In a way that&#x27;s immune to ransomware as well, so not just a RAID-1&#x2F;5&#x2F;Z or another form of hot&#x2F;warm storage (RAID is not a backup, it&#x27;s an uptime&#x2F;availability mechanism) but cold storage. (I snapshot and tar that snapshot every night, then back it up both on tape and in the cloud.)

&gt; This whole madness started because someone posted an attempt at a test case for a different issue, and then that test case started failing on versions of OpenZFS that didn’t even have the feature in question.<p>One will expect more seriosity from filesystem maintainers and serious regression testing before a release.