TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

A Philosophy of Code Review

4 点作者 _pastel27 天前

1 comment

taylodl27 天前
My thoughts on this approach:<p>- Yes, automate as much as possible. Lint, code formatters, and other analysis tools you may have at your disposable. The team needs to agree on the bar that must be met to submit the PR.<p>- Check the tests. If you&#x27;ve changed something, show me the tests that test that change. Most of my code review is analyzing the quality and coverage of your tests.<p>- I really don&#x27;t care much about your actual code - the automated tools already enforced our coding standards. I&#x27;m not much for coding standards; I&#x27;ll use whatever standard the team wants. I&#x27;m just glad they can be automatically enforced so I don&#x27;t have to engage in pointless arguments that only serve to lower team morale.<p>At the end of the day, I really only care about your tests.