TE
科技回声
首页24小时热榜最新最佳问答展示工作
GitHubTwitter
首页

科技回声

基于 Next.js 构建的科技新闻平台,提供全球科技新闻和讨论内容。

GitHubTwitter

首页

首页最新最佳问答展示工作

资源链接

HackerNews API原版 HackerNewsNext.js

© 2025 科技回声. 版权所有。

8 (new) steps for fixing other people’s code

9 点作者 BummerCloud超过 12 年前

1 comment

humbledrone超过 12 年前
I feel like a really important step is missing between steps 2 and 3: open an issue about the changes you'd like to make, and get feedback from the project maintainers. Unless you are just fixing an extremely obvious and simple bug, it is a really bad idea to just write up a pull request without getting an "I'd consider merging that" from a maintainer.<p>There are plenty of reasons that a pull request might get rejected. Perhaps a maintainer has already written some similar code and just hasn't merged it into a public branch. Maybe the approach you took isn't in line with the maintainer's vision. Maybe they just simply don't want to add the feature you want.<p>Randomly sending pull requests out of the blue is a good way to waste time and become frustrated. It's not very fun to write a bunch of code and have the maintainer just drop it on the floor.